Remove unnecessary RadioGroup migration TODOs (#180105)
Part of: https://github.com/flutter/flutter/issues/179088 Previous: * https://github.com/flutter/flutter/pull/179158 * https://github.com/flutter/flutter/pull/179091 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
@@ -64,9 +64,6 @@ void main() {
|
||||
.widget<RadioMenuButton<Color>>(
|
||||
find.byType(RadioMenuButton<Color>).at(0),
|
||||
)
|
||||
// TODO(loic-sharma): Migrate to RadioGroup.
|
||||
// https://github.com/flutter/flutter/issues/179088
|
||||
// ignore: deprecated_member_use
|
||||
.groupValue,
|
||||
equals(Colors.green),
|
||||
);
|
||||
@@ -86,9 +83,6 @@ void main() {
|
||||
.widget<RadioMenuButton<Color>>(
|
||||
find.byType(RadioMenuButton<Color>).at(0),
|
||||
)
|
||||
// TODO(loic-sharma): Migrate to RadioGroup.
|
||||
// https://github.com/flutter/flutter/issues/179088
|
||||
// ignore: deprecated_member_use
|
||||
.groupValue,
|
||||
equals(Colors.red),
|
||||
);
|
||||
@@ -108,9 +102,6 @@ void main() {
|
||||
.widget<RadioMenuButton<Color>>(
|
||||
find.byType(RadioMenuButton<Color>).at(0),
|
||||
)
|
||||
// TODO(loic-sharma): Migrate to RadioGroup.
|
||||
// https://github.com/flutter/flutter/issues/179088
|
||||
// ignore: deprecated_member_use
|
||||
.groupValue,
|
||||
equals(Colors.blue),
|
||||
);
|
||||
|
||||
@@ -8352,8 +8352,6 @@ typedef StatefulWidgetBuilder = Widget Function(BuildContext context, StateSette
|
||||
/// This example shows using an inline StatefulBuilder that rebuilds and that
|
||||
/// also has state.
|
||||
///
|
||||
// TODO(loic-sharma): Migrate to RadioGroup.
|
||||
// https://github.com/flutter/flutter/issues/179088
|
||||
/// ```dart
|
||||
/// await showDialog<void>(
|
||||
/// context: context,
|
||||
|
||||
Reference in New Issue
Block a user